Skip to content

Fix expand respecting fixed table column widths#2010

Open
bijesh-bits wants to merge 3 commits intospectreconsole:mainfrom
bijesh-bits:fix/table-column-width-expand
Open

Fix expand respecting fixed table column widths#2010
bijesh-bits wants to merge 3 commits intospectreconsole:mainfrom
bijesh-bits:fix/table-column-width-expand

Conversation

@bijesh-bits
Copy link

fixes #1989

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

  • Prevent Table.Expand() from distributing extra width into fixed-width columns.
  • Add a unit test that verifies a fixed-width column remains stable when expanding.

Testing

  • dotnet test src/Spectre.Console.Tests/Spectre.Console.Tests.csproj -c Release --filter FullyQualifiedName~TableTests

Please upvote 👍 this pull request if you are interested in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column width not applied unless a Rule() is present in one of the rows

1 participant

Comments